Skip to content

Implement subword completion for SQL editor#7945

Merged
matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing:subword_completion
Nov 21, 2024
Merged

Implement subword completion for SQL editor#7945
matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing:subword_completion

Conversation

@matthiasblaesing
Copy link
Copy Markdown
Contributor

Closes: #7912

@matthiasblaesing matthiasblaesing added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Nov 8, 2024
@matthiasblaesing matthiasblaesing added this to the NB25 milestone Nov 8, 2024
@mbien mbien added the SQL label Nov 18, 2024
Copy link
Copy Markdown
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me

@matthiasblaesing
Copy link
Copy Markdown
Contributor Author

@mbien thanks for review, @vulewuxe86 thanks for testing

@matthiasblaesing matthiasblaesing merged commit 41483e9 into apache:master Nov 21, 2024
@matthiasblaesing matthiasblaesing deleted the subword_completion branch November 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) SQL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subword completion for SQL

2 participants