Skip to content

Fix java/j2ee.persistence test and add it to build pipeline#7943

Merged
matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing:j2ee.persistence.test
Nov 14, 2024
Merged

Fix java/j2ee.persistence test and add it to build pipeline#7943
matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing:j2ee.persistence.test

Conversation

@matthiasblaesing
Copy link
Copy Markdown
Contributor

No description provided.

@matthiasblaesing matthiasblaesing added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Nov 7, 2024
@matthiasblaesing matthiasblaesing added this to the NB25 milestone Nov 7, 2024
@mbien mbien added the Java EE/Jakarta EE [ci] enable enterprise job label Nov 7, 2024
@mbien
Copy link
Copy Markdown
Member

mbien commented Nov 7, 2024

cool! Should we move this down to the enterprise job?

The java job is quite long already and I believe enterprise would also fit better for j2ee.* tests.

@matthiasblaesing
Copy link
Copy Markdown
Contributor Author

I have mixed feelings here. I agree, that when I read JPA, I immediately think JakartaEE, but JPA is perfectly capable of running standalone. What is more, contrary to many j2ee.* modules, j2ee.persistence is part of the java cluster, not the enterprise on. That is the reason I added it to the java set of test.

But I have no strong feelings here and can move.

@matthiasblaesing
Copy link
Copy Markdown
Contributor Author

@pepness you might also want to have a look. From my POV this was just a typo in the tests added in 6f869f2. Apart from fixing that, this PR just wires the tests to be run as part of the CI/CD pipeline.

@mbien
Copy link
Copy Markdown
Member

mbien commented Nov 10, 2024

I have mixed feelings here. I agree, that when I read JPA, I immediately think JakartaEE

If this would intuitively cause someone to set the enterprise or Jakarta label -> it would work as intended I think.

What is more, contrary to many j2ee.* modules, j2ee.persistence is part of the java cluster, not the enterprise on. That is the reason I added it to the java set of test.

The Java Modules job is a little bit of a catch-all job at the moment and is together with PHP the longest job with >40mins runtime. The Enterprise job is at 10 mins for comparison.

I was looking at it a bit from the load balancing perspective - I do also not feel strongly about it.

@matthiasblaesing
Copy link
Copy Markdown
Contributor Author

@mbien valid points. Test is moved.

@matthiasblaesing matthiasblaesing merged commit d92b25c into apache:master Nov 14, 2024
@matthiasblaesing matthiasblaesing deleted the j2ee.persistence.test branch November 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java EE/Jakarta EE [ci] enable enterprise job Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

Development

Successfully merging this pull request may close these issues.

2 participants