Skip to content

JS CDT Debugger: Improve path handling and remember connection settings#7931

Merged
matthiasblaesing merged 2 commits intoapache:masterfrom
matthiasblaesing:cdt_debug_windows
Dec 9, 2024
Merged

JS CDT Debugger: Improve path handling and remember connection settings#7931
matthiasblaesing merged 2 commits intoapache:masterfrom
matthiasblaesing:cdt_debug_windows

Conversation

@matthiasblaesing
Copy link
Copy Markdown
Contributor

  • JS CDT Debugger: Remember connection settings for remote attach
  • JS CDT Debugger: Improve handling of paths
  • CDT Protocol allows to store "names" in url fields, which ware not URL compatible and thus break parsing

Closes: #7797

Breaking change: URL fields in CDT protocol may hold urls and "names",
the latter are incompatible with URLs

Closes: apache#7797
@matthiasblaesing matthiasblaesing added JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor) TypeScript [ci] enable web job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Nov 1, 2024
@matthiasblaesing matthiasblaesing added this to the NB25 milestone Nov 1, 2024
@Chris2011
Copy link
Copy Markdown
Contributor

@matthiasblaesing will check it tomorrow, thx.

@Chris2011
Copy link
Copy Markdown
Contributor

@matthiasblaesing thx, it seems to work now :)

@matthiasblaesing
Copy link
Copy Markdown
Contributor Author

@Chris2011 thanks for checking

For anyone else reading: I plan to merge this by next weekend. If anyone want to object, please do so now.

@apache apache locked and limited conversation to collaborators Dec 8, 2024
@apache apache unlocked this conversation Dec 8, 2024
@matthiasblaesing
Copy link
Copy Markdown
Contributor Author

Just one month late. Lets get this in.

@matthiasblaesing matthiasblaesing merged commit 7f230e8 into apache:master Dec 9, 2024
@matthiasblaesing matthiasblaesing deleted the cdt_debug_windows branch January 9, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor) TypeScript [ci] enable web job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JS] Debugger doesn't stop at breakpoint when set

2 participants