Support for UserQuestionException during reloads#7904
Merged
sdedic merged 1 commit intoapache:masterfrom Jan 15, 2025
Merged
Conversation
dbalek
approved these changes
Oct 25, 2024
lahodaj
approved these changes
Oct 29, 2024
Contributor
lahodaj
left a comment
There was a problem hiding this comment.
Overall looks OK to me, with a nit suggestion inline.
| private AskEditorQuestions() { | ||
| } | ||
|
|
||
| public static Boolean askUserQuestion(UserQuestionException uqe) { |
Contributor
There was a problem hiding this comment.
A nit: it might be nicer to use a 3-constant enum instead of a Boolean. The enum could say YES, NO and ASK_USER, making the result more obvious.
cabce67 to
91b30af
Compare
Member
Author
|
Review comment applied, rebased on latest master + squashed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to step in even during reload, by throwing
BadLocationExceptionwith a wrappedUserQuestionException- will result in the question dialog for the user.For LSP/headless operation, a branding API is introduced that allows to skip question for *specified subclass of UserQuestionException - either always permit or always deny. Applications/distributions can control that using branding.