Skip to content

Open up and make accessible Resolver Public APIs#7777

Merged
mbien merged 1 commit intoapache:masterfrom
cstamas:open-up-resolver
Feb 13, 2025
Merged

Open up and make accessible Resolver Public APIs#7777
mbien merged 1 commit intoapache:masterfrom
cstamas:open-up-resolver

Conversation

@cstamas
Copy link
Copy Markdown
Member

@cstamas cstamas commented Sep 20, 2024

As documented here:
https://maven.apache.org/resolver/api-compatibility.html

Doing this is not only "right", but makes possible migration off the legacy classes, like shared.graph, shared.tree and many others are.

After migration, the list of friend classes should be narrowed down by dropping unused stuff.

@cstamas
Copy link
Copy Markdown
Member Author

cstamas commented Sep 20, 2024

Deprecated stuff like api.transform or spi.servicelocator and others intentionally left out, they are not needed (and are deprecated anyway).

@mbien mbien added the Maven [ci] enable "build tools" tests label Sep 20, 2024
@mbien
Copy link
Copy Markdown
Member

mbien commented Sep 20, 2024 

ag -l -E java DependencyTreeFactory
java/maven/src/org/netbeans/modules/maven/queries/MavenDependenciesImplementation.java
java/maven/src/org/netbeans/modules/maven/nodes/DependencyNode.java
java/maven/src/org/netbeans/modules/maven/dependencies/ExcludeDependencyPanel.java
java/maven.embedder/src/org/netbeans/modules/maven/embedder/DependencyTreeFactory.java
java/maven.repository/src/org/netbeans/modules/maven/repository/ui/ArtifactMultiViewFactory.java

the dated dep isn't used a lot luckily. we might be able to migrate this in one go - or at least some of it.

@cstamas
Copy link
Copy Markdown
Member Author

cstamas commented Sep 20, 2024

Yes, but things like ArtifactRepository (also deprecated in 3.9.x) have way bigger proliferation, and stands in way to support things like "split repository"... so there is quite some things to clean up.

@mbien
Copy link
Copy Markdown
Member

mbien commented Feb 2, 2025

@cstamas could you squash and rebase this to latest master (no hurry). NB 25 is baking right now, I think we should try to get this in for NB 26.

@mbien mbien added this to the NB26 milestone Feb 2, 2025
@mbien mbien mentioned this pull request Feb 2, 2025
Closed
@cstamas
Open up and make accessible Resolver Public APIs
be72c4d 
As documented here:
https://maven.apache.org/resolver/api-compatibility.html

Doing this is not only "right", but makes possible migration
off the legacy classes, like shared.graph, shared.tree and
many others are.

After migration, the list of friend classes should be narrowed
down by dropping unused stuff.
@mbien mbien marked this pull request as ready for review February 2, 2025 15:36
mbien
mbien approved these changes Feb 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for squashing!

Ran a smoke test and indexing, SMO, dependency graph etc all worked without classloading issues -> merging

@mbien mbien merged commit 1ddc32f into apache:master Feb 13, 2025
@mbien
Copy link
Copy Markdown
Member

mbien commented Feb 13, 2025

@cstamas congratulations on your first NetBeans contribution! :D

@cstamas cstamas deleted the open-up-resolver branch July 9, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbien mbien mbien approved these changes

Assignees

No one assigned

Labels

Maven [ci] enable "build tools" tests

Projects

None yet

Milestone

NB26

Development

Successfully merging this pull request may close these issues.

2 participants

@cstamas @mbien