Cleanup warnings that are related to the use of a Result raw type..#7597
Merged
BradWalker merged 1 commit intoapache:masterfrom Jan 14, 2025
Merged
Cleanup warnings that are related to the use of a Result raw type..#7597BradWalker merged 1 commit intoapache:masterfrom
BradWalker merged 1 commit intoapache:masterfrom
Conversation
0776319 to
9d43212
Compare
9d43212 to
f08d3c9
Compare
enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/admin/Runner.java
Outdated
Show resolved
Hide resolved
enterprise/payara.tooling/src/org/netbeans/modules/payara/tooling/admin/Runner.java
Outdated
Show resolved
Hide resolved
...se/websvc.clientapi/src/org/netbeans/modules/websvc/api/client/WebServicesClientSupport.java
Outdated
Show resolved
Hide resolved
...prise/websvc.clientapi/src/org/netbeans/modules/websvc/api/client/WebServicesClientView.java
Outdated
Show resolved
Hide resolved
...se/websvc.clientapi/src/org/netbeans/modules/websvc/api/jaxws/client/JAXWSClientSupport.java
Outdated
Show resolved
Hide resolved
platform/openide.loaders/src/org/openide/loaders/InstanceDataObject.java
Outdated
Show resolved
Hide resolved
platform/openide.loaders/src/org/openide/loaders/InstanceDataObject.java
Outdated
Show resolved
Hide resolved
platform/openide.loaders/src/org/openide/loaders/XMLDataObjectInfoParser.java
Outdated
Show resolved
Hide resolved
platform/openide.loaders/src/org/openide/loaders/XMLDataObjectInfoParser.java
Outdated
Show resolved
Hide resolved
platform/openide.loaders/src/org/openide/loaders/XMLDataObjectInfoParser.java
Outdated
Show resolved
Hide resolved
Contributor
|
@BradWalker could you please see if this is still intent for NB24? Given the unresolved comments, I would suggest to remove milestone and plan when there is time to work on this. |
8444a60 to
43414fb
Compare
Member
Author
Hey @matthiasblaesing , sorry to be delayed on responding. Thank you for the code review oversight. I think that I've fixed everything. Trying to clean up old pull requests before starting anything new. |
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
There are unanswered comments, so not sure if that is intentional.
...prise/websvc.clientapi/src/org/netbeans/modules/websvc/api/client/WebServicesClientView.java
Outdated
Show resolved
Hide resolved
...prise/websvc.clientapi/src/org/netbeans/modules/websvc/api/jaxws/client/JAXWSClientView.java
Outdated
Show resolved
Hide resolved
ide/editor.fold.nbui/src/org/netbeans/modules/editor/fold/ui/FoldViewFactory.java
Outdated
Show resolved
Hide resolved
43414fb to
b836208
Compare
Member
Author
|
Oversight on my part. Should be fixed now.. |
Warnings like this: [repeat] /home/bwalker/src/netbeans/ide/editor.fold.nbui/src/org/netbeans/modules/editor/fold/ui/FoldViewFactory.java:107: warning: [rawtypes] found raw type: Result [repeat] private Lookup.Result colorSource; [repeat] ^ [repeat] missing type arguments for generic class Result [repeat] where T is a type-variable: [repeat] T extends Object declared in class Result This pull request reduces many of those warnings.
b836208 to
27a48fc
Compare
matthiasblaesing
approved these changes
Jan 13, 2025
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. Thank you. The failing check is caused by the author in the commit entry. There is no space between your first and lastname. I don't think this needs a respin, but would be good to fix for next commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup warnings that are related to the use of a Result raw type..
Warnings like this:
[repeat] /home/bwalker/src/netbeans/ide/editor.fold.nbui/src/org/netbeans/modules/editor/fold/ui/FoldViewFactory.java:107: warning: [rawtypes] found raw type: Result
[repeat] private Lookup.Result colorSource;
[repeat] ^
[repeat] missing type arguments for generic class Result
[repeat] where T is a type-variable:
[repeat] T extends Object declared in class Result
This pull request reduces many of those warnings.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.