Merge back Windows launcher code and add release workflow#6869
Merge back Windows launcher code and add release workflow#6869neilcsmith-net merged 2 commits intoapache:masterfrom
Conversation
mbien
left a comment
There was a problem hiding this comment.
workflow looks good.
Not importing the history is probably fine in this case.
|
wondering if a java program compiled to native image could launch NB, analog to how the mvnd CLI client works which communicates with the daemon. |
|
@mbien have had that thought, too. Some easier replacement for the Windows launchers would be good to consider in a future update. In some ways, having the bulk of the logic in a script form could also be good to explore. The macOS Swift launcher is just a tiny stub that executes the shell script. Anyway, let's follow up on that on mailing list or Slack. Important thing initially is to find an easier way to include the existing functionality. |
f72daff to
8706227
Compare
|
Just updated the second (IDE) version file to match the one in bootstrap. Need to look at how we inject these from the action ideally. Currently set to |
8706227 to
b8e969a
Compare
|
I'll look to merge this tomorrow unless anyone has further comments or wants to request changes. cc/ @jlahoda if we can then bring the changes suggested in the separate repo on top of this, we should be able to proceed with a launcher release with those changes prior to freeze. |
|
I think this would close https://issues.apache.org/jira/browse/NETBEANS-1590 too once merged. I am mostly posting this because i would otherwise forget about it. |
|
@mbien in the short term, yes. We also need to not forget about finding a better way to manage versioning so that we don't let that issue recur. And also, how we progress from |
|
should https://github.com/apache/netbeans-native-launchers be archived? |
@mbien start a consensus thread on dev@ Likely will be asked for by infra to enact this change. |
This PR merges back the Windows native launcher code back into the main repo, and adds a GitHub workflow to build source and binary zips for release.
The first commit copies back files from https://github.com/apache/netbeans-native-launchers into their original locations. Unfortunately, at present, history from the separate repo is lost.
The second commit fixes paths and adds a GitHub workflow based on the dlight and profiler workflows. This builds a source and binary zip that we can release via dist.a.o in the same way as those other native binaries.
The workflow uses the same technique of building a source zip keeping the native libraries in their existing relative path locations. Separate isolated steps build the binary files and binary zip from that source zip (ensuring completeness of the sources).
Artefacts still need testing. A second PR will need generating to use the staged artefacts for test build and vote (see process used for other binaries).
As well as pending changes, we'll need to consider versioning in
versions.hand possibly whether that can be configured via environment variables that can be set via GH workflow??