Skip to content

Updated test results window#6695

Merged
mbien merged 1 commit intoapache:masterfrom
mbien:test-window-update
Jan 14, 2024
Merged

Updated test results window#6695
mbien merged 1 commit intoapache:masterfrom
mbien:test-window-update

Conversation

@mbien
Copy link
Copy Markdown
Member

@mbien mbien commented Nov 14, 2023 •
edited
Loading

  • flat look without gradients + new in-progress animation
  • visual indication that the stacktrace links are clickable
  • uninteresting stack frames (e.g from the junit testing framwork) are grayed out and not underscored
  • increased initial width of tree component via splitter location
  • added BUILD SUCCESS output line coloring, analog to failure msg
  • minor language level code cleanup in the touched files

test-results-update
test-results-update-2

todo:

  • ot tested with screen scaling enabled 2x scaling looks fine, that is the only scaling which works on my screen resolution.
  • only tested with junit/java, i think the UI is used with other languages too

@mbien mbien added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) UI User Interface tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Nov 14, 2023
@mbien mbien added this to the NB21 milestone Nov 14, 2023
@mbien mbien force-pushed the test-window-update branch 3 times, most recently from ced69c6 to 65271a4 Compare January 7, 2024 01:26
@mbien mbien marked this pull request as ready for review January 7, 2024 01:26
@mbien
Copy link
Copy Markdown
Member Author

mbien commented Jan 7, 2024

more cleanup

@neilcsmith-net is the animation acceptable?

@Chris2011
Copy link
Copy Markdown
Contributor

Chris2011 commented Jan 8, 2024

@mbien thx for this nicer UI now. Changing the icons should not be part of this PR too? I would suggest to change them too here.

@mbien
Copy link
Copy Markdown
Member Author

mbien commented Jan 12, 2024

@junichi11 could you check that this doesn't break anything in the PHP test output UI? I think this should be fine but just to be sure. I don't know enough about php to come up with all the use cases.

@junichi11
Copy link
Copy Markdown
Member

junichi11 commented Jan 12, 2024

@mbien Looks good to me.

nb-pr-6695-1

nb-pr-6695-2

nb-pr-6695-3

I think we should also change the coverage later.

nb-pr-6695-4

nb-pr-6695-5

cc: @tmysik

@tmysik
Copy link
Copy Markdown
Member

tmysik commented Jan 12, 2024

@junichi11

Thanks for testing it. I totally agree that changing the code coverage UI in the same way would be nice (now, it is kind of ugly :)

Junichi, what do you think about the changes in the stack traces? I mean the color and (no) possibility to click on the lines? 🤔

Thanks!

@junichi11
Copy link
Copy Markdown
Member

junichi11 commented Jan 12, 2024

@tmysik There seems to be no problem :)

nb-gh-6695-6

@mbien
Copy link
Copy Markdown
Member Author

mbien commented Jan 12, 2024

Junichi, what do you think about the changes in the stack traces? I mean the color and (no) possibility to click on the lines? 🤔

@tmysik I changed this only in the JUnitCallstackFrameNode which should be hopefully java only as the name says. Did the behavior change for PHP or is it like before? Thanks for testing and the feedback!

@tmysik
Copy link
Copy Markdown
Member

tmysik commented Jan 13, 2024

@mbien @junichi11

Junichi, thanks for the verification!

Michael, yes, I would not expect that changing JUnit module would change also any PHP one but who knows 😅

What I meant more is that in (not only) PHP, we should perhaps try to be consistent - that means to make links perhaps only for project PHP files? OTOH, I can imagine a use-case when a user wants to navigate into the framework sources to see what exactly is happening there... just brainstorming.

@mbien
Copy link
Copy Markdown
Member Author

mbien commented Jan 13, 2024

yes I agree the progress bars should be adjusted too to match the style. I don't know if i have time tomorrow so I remove NB21 milestone for now.

@mbien mbien removed this from the NB21 milestone Jan 13, 2024
@mbien
Updated test results window and test coverage bar
3917a2a 
 - flat look without gradients + new in-progress animation
 - visual indication that the stacktrace links are clickable
 - uninteresting stack frames (e.g from the junit testing framework)
   are grayed out and not underscored
 - increased initial width of tree component via splitter location
 - added BUILD SUCCESS output line coloring, analog to failure msg
 - minor code cleanup in the touched files
@mbien mbien added this to the NB21 milestone Jan 14, 2024
@mbien mbien force-pushed the test-window-update branch from 65271a4 to 3917a2a Compare January 14, 2024 04:01
@mbien
Copy link
Copy Markdown
Member Author

mbien commented Jan 14, 2024 •
edited
Loading

i quickly updated the test coverage bar to the same flat look. @tmysik @junichi11 please check if it is working as expected.
I don't have any php testing framework installed so I tested this just with dummy values (I am no php dev as you know).

@junichi11
Copy link
Copy Markdown
Member

junichi11 commented Jan 14, 2024

Looks good :) Thanks!

nb-pr-6695-coverage-1

nb-pr-6695-coverage-2

@tmysik
Copy link
Copy Markdown
Member

tmysik commented Jan 14, 2024

Perfect! Thanks a lot, guys!

@mbien
Copy link
Copy Markdown
Member Author

mbien commented Jan 14, 2024

ok, thanks again to everyone for testing. Lets merge it for NB21.

@mbien mbien merged commit 8d2aec2 into apache:master Jan 14, 2024
@Chris2011
Copy link
Copy Markdown
Contributor

Chris2011 commented Jan 14, 2024

Probably my comment was overseen, but shouldn't we changed the icons also in this PR? The idea was to make at least this section consistent. And if this is not possible anymore after merge, we should have this in our mind for the next ones. Thx for your work.

@albilu
Copy link
Copy Markdown
Contributor

albilu commented Apr 15, 2024

@mbien Great work!
I am planning to work on the test runner with this ticket #6871
Can you give me some hints regarding what updates need to be done. I am not very good with ant
I ask in the dev mailing list couple of months ago without any feedback

@mbien
Copy link
Copy Markdown
Member Author

mbien commented Apr 16, 2024 •
edited
Loading

I am planning to work on the test runner with this ticket 6871
Can you give me some hints regarding what updates need to be done. I am not very good with ant

@albilu building NB is fairly easy: https://github.com/apache/netbeans?tab=readme-ov-file#building-netbeans

once build you open the modules you are interested in in NB and can make changes to them. You can build/debug/run them directly from within NB like a maven project.

The module dependencies are in each modules project.xml file (e.g https://github.com/mbien/netbeans/blob/3917a2a04e5af314b9b21e754c5097e05b2fcd90/ide/gsf.codecoverage/nbproject/project.xml). Most of it can be edited using the regular project properties UI (right click on project).

So you would have to identify what internal API you want to access too, then make it public. (I haven't really looked into the API yet, It might be just a matter of switching it from internal/friend to public)

@mbien mbien mentioned this pull request Nov 7, 2024
Merged
@mbien mbien mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neilcsmith-net neilcsmith-net neilcsmith-net left review comments

Assignees

No one assigned

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) tests UI User Interface

Projects

None yet

Milestone

NB21

Development

Successfully merging this pull request may close these issues.

6 participants

@mbien @Chris2011 @junichi11 @tmysik @albilu @neilcsmith-net