Conversation
JaroslavTulach
left a comment
There was a problem hiding this comment.
Modify nbbuild/cluster.properties to include this module. Modify nbbuild/build.properties to include the new Javadoc. Hopefully then the module becomes subject to license & co. checks.
...e/cloud.oracle/test/unit/src/org/netbeans/modules/cloud/oracle/DownloadWalletDialogTest.java
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/OpenServiceConsoleAction.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/DownloadWalletAction.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /** | ||
| * Creates and downloads a wallet for the specified Autonomous Database. |
There was a problem hiding this comment.
Where the downloaded wallet is stored?
enterprise/cloud.oracle/src/org/netbeans/api/cloud/oracle/DatabaseItem.java
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/api/cloud/oracle/OCIItem.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/DatabaseNode.java
Outdated
Show resolved
Hide resolved
JaroslavTulach
left a comment
There was a problem hiding this comment.
Wrapping libraries into modules, updating versions of some libraries - looks like good job. Creating and using the @CloudProvider looks fine as well. I don't see problems from architecture perspective.
enterprise/cloud.oracle/external/j2objc-annotations-1.3-license.txt
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/DatabaseNode.java
Show resolved
Hide resolved
| * | ||
| * @author Jan Horvath | ||
| */ | ||
| public class OCIItem { |
There was a problem hiding this comment.
The OCIItem would then be the API of this module... but right now it would be private API as the class isn't exposed.
| } | ||
|
|
||
| @Override | ||
| public void stateChanged(ChangeEvent e) { |
There was a problem hiding this comment.
Looks like empty implementation.
JaroslavTulach
left a comment
There was a problem hiding this comment.
What's the license for enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/resources/orcl.png? There should be licenseinfo.xml file specifying that. Btw. are you sure the compartment and database .svg files are really licensed under Apache license?
|
Except the image licenses (which Jan Horváth will clarify) I consider the integration solid. Any other review comments? Otherwise I plan to merge this week. |
matthiasblaesing
left a comment
There was a problem hiding this comment.
As @JaroslavTulach already pointed out the PNG needs a license to it enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/resources/orcl.png.
The rest of the changes looks ok to me (only eyeballed!).
For the library updates, this duplicates/overrides #2287. It would be good if the bcpg module would then also be updated.
In general this PR needs cleanup, we should not merge this with 28 commits. After review and before merge these should either be fully squashed into a single commit or squashed based on logical units.
matthiasblaesing
left a comment
There was a problem hiding this comment.
Before this is merged PLEASE SQUASH!
|
All green two approvals, changes squashed. Merging. |
|
Thanks @sdedic Please make sure to check and add the milestone when merging. |
Adding new module with support for Oracle Cloud. For now it is able to browser Tenancy and Compartments. In selected Compartment it shows Autonomous Databases and allow to create and download Database Wallet.