Netbeans license headers cleanup check-in #1#2281
Conversation
BradWalker
commented
Jul 30, 2020
Add missing ALv2 license headers to form files.
|
@BradWalker |
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. @junichi11 I don't think the "#1" in the commit message is a deal breaker. That github decided to try to gather information from plain text insteaf of structured information is a problem of github, not Brad. Try to add some random "@" into messages and a random number of people get CCed.
In any case, @BradWalker will need a committer to commit this, so please indicate if you require an updated commit message, commit this yourself, or want me to merge it.
I didn't mean that. Actually, I approved this. I just would like to avoid unnecessary notification/link. I meant I suggest use another one (from next time; It's OK with me to merge this as it is) if we need not use |
|
Hey @junichi11 and @matthiasblaesing, thanks for the feedback.. I would NEVER have known that GitHub was trying to parse my pull request for notification.. Thanks.. I'll be more careful next time.. Can @junichi11 commit my changes for me? Thanks to both of you! |
|
@BradWalker Never mind :) Merging. |
|
Thanks to the both of you. 👍 |