[NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too#1504
Merged
geertjanw merged 3 commits intoapache:masterfrom Sep 16, 2019
lbruun:cleaner-remove-readonly-too
Merged
[NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too#1504geertjanw merged 3 commits intoapache:masterfrom lbruun:cleaner-remove-readonly-too
geertjanw merged 3 commits intoapache:masterfrom
lbruun:cleaner-remove-readonly-too
Conversation
files too. - Attempt to remove read-only attrib on a file/folder before attempting to delete it. - Also added braces on existing statements to make the code more readable.
Member
|
Looks good to me. |
neilcsmith-net
approved these changes
Sep 16, 2019
Member
neilcsmith-net
left a comment
There was a problem hiding this comment.
Fine in principle. Feel free to merge. Should be squashed despite comment against?
Member
|
Following request to not squash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Windows NBI cleaner process fails to delete files/folders if they have the read-only attribute set. With this change the cleaner will - in such case - attempt to remove the read-only attribute before proceeding to delete the file/folder.
I've deliberately not squashed as each commit is a story of its own.