[NETBEANS-2751] OpenJFX Samples#1503
Merged
geertjanw merged 2 commits intoapache:masterfrom Sep 15, 2019
geertjanw:netbeans-2571-openjfx-samples
Merged
[NETBEANS-2751] OpenJFX Samples#1503geertjanw merged 2 commits intoapache:masterfrom geertjanw:netbeans-2571-openjfx-samples
geertjanw merged 2 commits intoapache:masterfrom
geertjanw:netbeans-2571-openjfx-samples
Conversation
Member
Author
Member
Author
|
This should go into 11.2, hope my adding the nb11.2 label helps to achieve that. |
matthiasblaesing
approved these changes
Sep 14, 2019
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
With a minor comment (see inline) this looks good
| <folder name="Standard"> | ||
| <folder name="JavaFX"> | ||
| <attr name="position" intvalue="110"/> | ||
| <attr name="displayName" bundlevalue="org.netbeans.modules.javafx2.samples.Bundle#Templates/Project/Samples/JavaFX"/> |
Contributor
There was a problem hiding this comment.
This bundle value does not exist anymore. See the change in Bundle.properties, line 25:
Member
Author
|
Thanks, fixed. |
Member
Author
|
Also thanks for liking and approving it. |
Member
Author
|
I don’t think this is a fundamental change, just a little bit of reorganization, i.e., a lot of debate and discussion is not needed for this one (correct me if I am wrong and reopen if applicable) and so I am merging this now. |
|
Thanks for removing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This does the following: