Skip to content

[NETBEANS-2751] OpenJFX Samples#1503

Merged
geertjanw merged 2 commits intoapache:masterfrom
geertjanw:netbeans-2571-openjfx-samples
Sep 15, 2019
Merged

[NETBEANS-2751] OpenJFX Samples#1503
geertjanw merged 2 commits intoapache:masterfrom
geertjanw:netbeans-2571-openjfx-samples

Conversation

@geertjanw
Copy link
Copy Markdown
Member

@geertjanw geertjanw commented Sep 14, 2019

This does the following:

  • Integrates the OpenJFX Gluon samples correctly, using their new 0.0.3 release.
  • Restructures the Samples category in the New Project dialog in "Java with Maven" and "Java with Ant", just like the project types were organized in that way in 11.1.
  • Tries to hide the Ant-based JavaFX samples a bit, since we want to encourage the usage of Maven rather than Ant, i.e., in the same way as the project types at the top of the dialog prioritize Maven, now the samples do as well.
  • Removes the module that was added in 11.1 that did not optimally integrate the OpenJFX Gluon samples. (Only the module needed to be removed, not the references to it in cluster.properties and elsewhere, since these were not in main to begin with, only in release111 and never moved to main.)

@geertjanw
Copy link
Copy Markdown
Member Author

Screen Shot 2019-09-14 at 20 39 33

That's the new structure in the Samples category from this pull request.

@geertjanw
Copy link
Copy Markdown
Member Author

This should go into 11.2, hope my adding the nb11.2 label helps to achieve that.

Copy link
Copy Markdown
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a minor comment (see inline) this looks good

<folder name="Standard">
<folder name="JavaFX">
<attr name="position" intvalue="110"/>
<attr name="displayName" bundlevalue="org.netbeans.modules.javafx2.samples.Bundle#Templates/Project/Samples/JavaFX"/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bundle value does not exist anymore. See the change in Bundle.properties, line 25:

@geertjanw
Copy link
Copy Markdown
Member Author

Thanks, fixed.

@geertjanw
Copy link
Copy Markdown
Member Author

Also thanks for liking and approving it.

@geertjanw
Copy link
Copy Markdown
Member Author

I don’t think this is a fundamental change, just a little bit of reorganization, i.e., a lot of debate and discussion is not needed for this one (correct me if I am wrong and reopen if applicable) and so I am merging this now.

@geertjanw geertjanw merged commit f5cbe38 into apache:master Sep 15, 2019
@junichi11 junichi11 added this to the 11.2 milestone Sep 15, 2019
@JaroslavTulach
Copy link
Copy Markdown

Thanks for removing the javafx/openjfx.samples module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants