[NETBEANS-2953] Fix for NPE after pressing 'DTDs and XML Schemas' men…#1491
Merged
geertjanw merged 1 commit intoapache:masterfrom Sep 14, 2019
Merged
[NETBEANS-2953] Fix for NPE after pressing 'DTDs and XML Schemas' men…#1491geertjanw merged 1 commit intoapache:masterfrom
geertjanw merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@jGauravGupta as this is Payara related, would you be kind enough to check you are happy with this very minor change? :) cheers! |
Member
|
Thanks, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pull request does
Prevents Netbeans from crashing with a NPE when selecting Tools -> DTDs and XML Schemas
Files Changed
enterprise/payara.jakartaee/src/org/netbeans/modules/payara/jakartaee/layer.xml
Changed so that the method used when registering is getDefaultRuntimeDDCatalog() instead of getRuntimeDDCatalog(). This now matches the equivilent method called when registering GlassFish DD catalog - getEE6RunTimeDDCatalog()
Testing
Navigate to Tools menu -> DTD and XML Schemas
Before this PR: NB will crash with a NPE
After this PR: The Enterprise Catalog dialog will open successfully