call ble_gap_event_listener_call for every ble_gap_notify_tx_event#671
Merged
andrzej-kaczmarek merged 1 commit intoapache:masterfrom Nov 20, 2019
HendrikVE:gap_event_listener_notify_tx
Merged
call ble_gap_event_listener_call for every ble_gap_notify_tx_event#671andrzej-kaczmarek merged 1 commit intoapache:masterfrom HendrikVE:gap_event_listener_notify_tx
andrzej-kaczmarek merged 1 commit intoapache:masterfrom
HendrikVE:gap_event_listener_notify_tx
Conversation
Needed to get the notification transmitted event with a listener registered by ble_gap_event_listener_register to be able to chain ble notifications. If there are two different modules on different application levels and both are using nimble, then it is not possible for the lower-level module to register a "feature-complete" callback via ble_gap_adv_start, because this function should only be called by the higher-level module, because it knows, when the application is ready for advertising.
andrzej-kaczmarek
approved these changes
Nov 20, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a call to the listener for
notify_txonly, but it might be desirable to also catch some other events.As discussed on slack, it is needed to get the notification transmitted event with a listener
registered by
ble_gap_event_listener_registerto be able to chain ble notifications.If there are two different modules on different application levels and both are using nimble, then it is not possible for the lower-level module to register a "feature-complete" callback via
ble_gap_adv_start, because this function should only be called by the higher-level module, because it knows, when the application is ready for advertising.