Skip to content

[MSITE-843] Downgrade Jetty to 9.2.28#9

Closed
Tibor17 wants to merge 1 commit intomasterfrom
jetty929
Closed

[MSITE-843] Downgrade Jetty to 9.2.28#9
Tibor17 wants to merge 1 commit intomasterfrom
jetty929

Conversation

@Tibor17
Copy link
Copy Markdown
Contributor

@Tibor17 Tibor17 commented Jul 5, 2019

@Tibor17 Tibor17 mentioned this pull request Jul 5, 2019
Merged
michael-o
michael-o requested changes Jul 5, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@michael-o michael-o left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejecting this PR because:

  • The most recent version of Jetty 9.2 is 9.2.28.v20190418
  • Revert of Lambas is not related to Jetty, this must be done separate: new ticket revert Java 8 move

@Tibor17 Tibor17 changed the title [MSITE-843] Upgrade Jetty to 9.2.9 with Jetty Security artifact [MSITE-843] Upgrade Jetty to 9.2.28.v20190418 with Jetty Security artifact Jul 6, 2019
@Tibor17
Copy link
Copy Markdown
Contributor Author

Tibor17 commented Jul 6, 2019

Now the version of Jetty in POM is 9.2.28.v20190418 from April 2019.

@Tibor17
Copy link
Copy Markdown
Contributor Author

Tibor17 commented Jul 7, 2019

@michael-o
I can make a new branch for J7 but the maven-enforcer-plugin would fail. Finally the build would pass again after this PR was rebased from master.

@Tibor17
Copy link
Copy Markdown
Contributor Author

Tibor17 commented Jul 7, 2019

Revert of Lambas is not related to Jetty, this must be done separate: new ticket revert Java 8 move

done in #10

@michael-o
Copy link
Copy Markdown
Member

michael-o commented Jul 7, 2019

OK, let's finish #10 and then continue here.

@Tibor17
Copy link
Copy Markdown
Contributor Author

Tibor17 commented Jul 7, 2019

@michael-o
i have renamed the commit msg according Jira.

@michael-o
Copy link
Copy Markdown
Member

michael-o commented Jul 7, 2019

ITs are running on Jenkins...

@asfgit asfgit closed this in 30428f0 Jul 7, 2019
@Tibor17
Copy link
Copy Markdown
Contributor Author

Tibor17 commented Jul 7, 2019

@michael-o
What will be the next step with the branch https://github.com/apache/maven-site-plugin/tree/MSITE-843, thx.

@michael-o
Copy link
Copy Markdown
Member

michael-o commented Jul 7, 2019

You can drop it. I have merged both branches into master.

@Tibor17 Tibor17 deleted the jetty929 branch July 7, 2019 22:17
@Tibor17 Tibor17 changed the title [MSITE-843] Upgrade Jetty to 9.2.28.v20190418 with Jetty Security artifact [MSITE-843] Downgrade Jetty to 9.2.28 Jul 8, 2019
@jira-importer
Copy link
Copy Markdown

jira-importer commented Jun 15, 2025

Resolve #980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tibor17 @michael-o @jira-importer