[MSHARED-983] Drop plexus container default #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The complete container was only here to make use of AbstractLogEnabled ancient class, that uses ancient logging. Drop it.
slachiewicz
approved these changes
Apr 29, 2021
elharo
reviewed
Apr 29, 2021
Contributor
elharo
left a comment
There was a problem hiding this comment.
This change is not API compatible. It deserves at least a minor version update and preferably a major version update.
As this change is not API compatible
elharo
approved these changes
Apr 30, 2021
Contributor
elharo
left a comment
There was a problem hiding this comment.
Is there a PMC member who can create a maven-shared-utils 4.0.0 release label in Jira? or perhaps change the 3.4.0 label to 4.0.0?
Member
Author
created https://issues.apache.org/jira/projects/MSHARED/versions/12350135 |
Member
|
Nice,with this new version we can also require java 8 (as separate ticket) |
Contributor
|
running through jenkins: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-shared-utils/job/MSHARED-983/ |
|
Resolve #322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MSHARED-983
The complete container was only here to make use of AbstractLogEnabled
ancient class, that uses ancient logging.
Changes: