Test, fix, and deprecate buggy copyDirectory methods #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be ignored. Deprecate these methods in favor of better maintained and documented Apache Commons IO methods from which they were copied and pasted 10+ years ago.
michael-o
approved these changes
Feb 14, 2021
|
Resolve #284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michael-o
I found this when I unignored an ignored test. And then I made the mistake of pulling on that string.
Unignore copyDirectory tests and fix broken behavior that caused them to be ignored. Deprecate these methods in favor of better maintained and documented Apache Commons IO methods from which they were copied and pasted 10+ years ago.