[MSHARED-822] MessageBuilder should support colored Paths #6
Conversation
michael-o
left a comment
There was a problem hiding this comment.
Why are there env var? I am not convinced using them. We have Maven properties as well as System properties for this.
src/test/java/org/apache/maven/shared/utils/logging/AnsiMessageBuilderTest.java
Outdated
Show resolved
Hide resolved
|
We used solely system properties first, but it didn't work. Investigated together with @rfscholte and it turns out that some in Maven distributions the |
Yes, hyperlinks won't work, nor would colors. It requires a different MessageBuilder next to AnsiMessageBuilder, something like HtmlMessageBuilder. Title is still valid: paths should have a separate display method. |
|
The |
Co-authored-by: Maarten Mulders <maartenm@infosupport.com>
Since it disables test cases and prints to System.out, this is definitely not in a state of merging!
src/main/java/org/apache/maven/shared/utils/logging/AnsiMessageBuilder.java
Show resolved
Hide resolved
|
I've attached a few screenshots with different colouring schemes on two types of terminals to the JIRA issue. |
It wasn't always set properly, but I think with Root-reactor aware subfolder builds in Maven 4, it may be more reliable... |
|
No immediate need for this, but it would be a nice little gem. The current implementation might need some refactoring, moving logic out of the |
|
Resolve #272 |
Together with Robert Scholte we figured that the idea of hyperlink output is not that easy. Instead, we came with a different idea to color file paths. It is depicted in the JIRA issue.