Slawomir Jaranowski opened MSHARED-971 and commented

In org.apache.maven.shared.invoker.MavenCommandLineBuilder

https://github.com/apache/maven-invoker/blob/d58703dd592ba0bc6f0a09928d0cce90e4002af9/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java#L197-L242

we have code:

        if ( request.isShellEnvironmentInherited() )
        {
                cli.addSystemEnvironment();
         }

but in org.apache.maven.shared.utils.cli.Commandline we have:

public String[] getEnvironmentVariables()
   {
       addSystemEnvironment();
      ...
    }

System environment variable are always added - it is inconsistent implementation.

Issue Links:

• MSHARED-1014 Optionally inherit system environment variables by Commandline
  ("is blocked by")
• MSHARED-969 Environment variable with null value

Remote Links:

• GitHub Pull Request #79
  

0 votes, 7 watchers