Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/maven-shade-plugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: rmannibucau/maven-shade-plugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: MSHADE-391
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on May 23, 2021

  1. [MSHADE-391] Do not write modified class files for no-op relocations 

    Also, rename method 'DefaultShader.shadeSingleJar' to 'shadeJarEntry' in
order to reflect what it actually does: It does *not* shade a JAR but a
JAR entry, i.e. not a "single JAR" but rather a single file.
    @kriegaex
    kriegaex committed May 23, 2021
    Configuration menu
    Copy the full SHA
    c755ad4 View commit details
    Browse the repository at this point in the history

  2. [MSHADE-391] Add integration test 

    Test src/it/projects/MSHADE-391_noRelocationKeepOriginalClasses shades
two dependencies, relocating one of them. For the non-relocated one, it
compares pre-calculated MD5 checksums to the actual ones in the uber
JAR, making sure that they are identical. The test will fail in Maven
Shade 3.2.4 or older, but pass with the changes made in MSHADE-391.
    @kriegaex
    kriegaex committed May 23, 2021
    Configuration menu
    Copy the full SHA
    626b2eb View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. [MSHADE-391] drop the threadlocal in favor of a remapper instance per… 

    … visitor to host the state in the visitor
    @rmannibucau
    rmannibucau committed May 24, 2021
    Configuration menu
    Copy the full SHA
    50e101f View commit details
    Browse the repository at this point in the history
Loading