Skip to content

[SCM-1028] Vulnerability: Clear text password is logged by JGit provider and by gitexe remoteinfo on a ls-remote failure #1254

@jira-importer

Description

@jira-importer

Markus Hoffrogge opened SCM-1028 and commented

Issue(s):

  1. {}JGit provider{}: If the git password contains special characters which are differently encoded by the URI class than {}by URLEncode.encode{}, then the password masking does not become effective and the password is logged in clear URI encoded format by the jgit provider.
  2. {}Gitexe remoteinfo{}: In case ls-remote is failing, then a ScmException is being thrown with the fetch URL passed as error message containing the URI encoded clear password.

Root cause(s):

  1. The URL encoding used for the credentials within fetch and push URL differs from the encoding being used for masking the password at JGitUtils.prepareSession(...)
  2. Password is not masked for the exception message passed to the ScmException used at GitRemoteInfoCommand.executeRemoteInfoCommand(...)

Solution:

PR #237


Affects: 2.1.0

Remote Links:

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingpriority:criticalCrashes, loss of data, severe memory leak

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions