Skip to content

Conversation

@olamy
Copy link
Member

@olamy olamy commented Nov 22, 2022

those files are specific to m2e they shouldn;t be stored in the Apache Maven sources

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MRESOURCES-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MRESOURCES-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

those files are specific to m2e they shouldn;t be stored in the Apache Maven sources
@olamy olamy added the removed Pull requests that remove features label Nov 22, 2022
@olamy
Copy link
Member Author

olamy commented Nov 22, 2022

cc @HannesWell @kwin

Copy link

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting us know.

This change should be safe and should not break existing M2E installations because the maven-resources-plugin is also handled in M2E default lifecycle-mappings, which should jump in:

https://github.com/eclipse-m2e/m2e-core/blob/master/org.eclipse.m2e.core/lifecycle-mapping-metadata.xml#L17-L33

Don't know why this duplication exists.

@cstamas cstamas merged commit 22d64ca into master Mar 21, 2023
@cstamas cstamas deleted the remove-m2e-files branch March 21, 2023 10:23
@alexsuter
Copy link

Seems that this change has broken our Eclipse IDE integration. Don't know why this is no longer working, yet.

@olamy
Copy link
Member Author

olamy commented Mar 28, 2023

@alexsuter sorry for that but according to this comment #40 (review) it shouldn’t have.

@HannesWell
Copy link

Seems that this change has broken our Eclipse IDE integration. Don't know why this is no longer working, yet.

Please try out the latest version of the Eclipse Maven integration m2e at https://download.eclipse.org/technology/m2e/releases/latest/
and if it still does not work please create a bug report at https://github.com/eclipse-m2e/m2e-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

removed Pull requests that remove features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants