JDK Transport: Do no longer leverage temp file for transfering artifact#1755
Merged
JDK Transport: Do no longer leverage temp file for transfering artifact#1755
Conversation
kwin
commented
Jan 16, 2026
...-test-http/src/main/java/org/eclipse/aether/internal/test/util/http/HttpTransporterTest.java
Outdated
Show resolved
Hide resolved
3ed3e8c to
5b011e1
Compare
Member
|
Where are we with this? |
Member
Author
|
I need to relax some more ITs |
8 tasks
ae65795 to
4c7d694
Compare
cstamas
reviewed
Jan 29, 2026
| } | ||
| notifyProgress(b, 0, numBytesRead); | ||
| } | ||
| return super.read(b); |
Member
There was a problem hiding this comment.
Looks good, but one thing bothers me: how did double invocation slipped thru UT? Why did not it fail? We obviously don't test this path? Or we don't validate what we got?
Member
Author
There was a problem hiding this comment.
Usually only the read with 3 arguments is used (e.g. when copying to an output stream). Would require dedicated unit tests to cover this
Member
Author
There was a problem hiding this comment.
Added a unit test with a little help from Claude.
with PUT Directly transfer based on the PutTask's InputStream. Improve retry handling to not retry (some) BodyPublisher exceptions.
dce23de to
9d141ef
Compare
cstamas
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with PUT
Directly transfer based on the PutTask's InputStream. Improve retry handling to not retry (some) BodyPublisher exceptions.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.