Skip to content

Add retries for JDK HTTP client#1735

Merged
kwin merged 1 commit intomasterfrom
feature/jdk-http-transport-retries
Jan 7, 2026
Merged

Add retries for JDK HTTP client#1735
kwin merged 1 commit intomasterfrom
feature/jdk-http-transport-retries

Conversation

@kwin
Copy link
Copy Markdown
Member

@kwin kwin commented Jan 7, 2026

Add tests for retries after 429 ("Too Many Requests") This closes #1732

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@kwin kwin requested a review from cstamas January 7, 2026 19:19
@kwin kwin force-pushed the feature/jdk-http-transport-retries branch from 1c19b68 to 20c549d Compare January 7, 2026 19:22
@kwin kwin force-pushed the feature/jdk-http-transport-retries branch from 20c549d to dbf1449 Compare January 7, 2026 20:32
@kwin
Copy link
Copy Markdown
Member Author

kwin commented Jan 7, 2026

@cstamas I think the added test reveals an error within Jetty which seems to interpret the retry parameters differently.

Update: Nevermind, seems that rate limiting is also a missing feature in Jetty.

Add tests for retries after 429 ("Too Many Requests")
This closes #1732
@kwin kwin force-pushed the feature/jdk-http-transport-retries branch from dbf1449 to 2d52647 Compare January 7, 2026 20:40
@kwin kwin merged commit 4ab57b9 into master Jan 7, 2026
33 of 34 checks passed
@kwin kwin deleted the feature/jdk-http-transport-retries branch January 7, 2026 21:24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2026

@kwin Please assign appropriate label to PR according to the type of change.

@github-actions github-actions bot added this to the 2.0.15 milestone Jan 7, 2026
@kwin kwin added the enhancement New feature or request label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JDK HTTP Client: Implement retry handling for 429/503 status codes and certain IOExceptions

2 participants