Merged
Conversation
A new SPI that offers ability to augment Resolver locking and inhibit locking on certain resources. Out of the box RRF prefix file inhibition is provided. Fixes apache#1663 Fixes apache#1641
gnodet
reviewed
Dec 1, 2025
| * May provide a predicate for artifacts that needs lock inhibition. <em>Warning: you do not want to override | ||
| * this method, or if you do, think twice.</em> | ||
| */ | ||
| default Optional<Predicate<Artifact>> inhibitArtifactLocking() { |
Contributor
There was a problem hiding this comment.
That looks over engineered.
Why not a simple
default boolean inhibitLock(Artifact artifact) {
return false;
}
default boolean inhibitLock(Metadata metadata) {
return false;
}
gnodet
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new SPI that offers ability to augment Resolver locking and inhibit locking on certain resources.
Out of the box RRF prefix file inhibition is provided.
Fixes #1663
Fixes #1641