Merged
Conversation
Member
Author
|
Thought: what if remote publishes wrong prefix? So we need some means or maybe revert the logic: try user provided, if not found, discover? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High level new features and changes:
.repoId=false.GroupId filter
Is enabled by default (but remains dormant if user does not provides input). It becomes active only when user provides input for it.
Input vastly improved and now supports modifiers as well (Resolver 1.x modus operandi was
=org.apacheONLY). Hence, upgrading from Resolver 1.x to Resolver 2.x leads to "broadened" filtering but that is fine is was user usually wants (Resolver 1.x had to enumerate all Gs for nested G, ieorg.apache.maven,org.apache.maven.pluginsetc... same effect with Resolver 2.x is one liner:org.apache.maven(as it means now "and below"). Added support for negation (!) and limiter (=). Example groupId filter file:Lines 1, 2 ignored. Line 3 "allow
org.apache.mavenand below". Line 4 "not alloworg.apache.maven.fooonly". Line 5 "not alloworg.apache.maven.indexerand below". Line 6 "alloworg.apache.baronly".Prefix filter
Is enabled by default and improved to try to auto-discover prefix file published by remote repository. If prefix file is discovered, common resolver means are used to resolve and cache the prefix file in user local repository. If discovery fails, user provided prefix file is attempted (and used, if found). Finally, if no input, filter will not interfere. Order of precedence:
Caching is now possible with fix done in #1491