Skip to content

Remove unused elements #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slawekjaranowski merged 2 commits into from
Jan 27, 2025
Merged

Remove unused elements #349

slawekjaranowski merged 2 commits into from
Jan 27, 2025

Conversation

@pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jan 17, 2025 •
edited
Loading

Locally ITs seem to be happy.
Compiler works fine with new source:

$ javap -p maven-plugin-plugin/target/it/v4api-3x/target/classes/org/apache/maven/its/v4api/HelpMojo.class| grep writeP
  private void writeParameter(java.lang.StringBuilder, org.w3c.dom.Node) throws org.apache.maven.api.plugin.MojoException;

@pzygielo pzygielo changed the title Remove unused local variable Remove unused elements Jan 17, 2025
@pzygielo pzygielo marked this pull request as ready for review January 17, 2025 10:24
@pzygielo

This comment was marked as outdated.

Sign in to view
1 similar comment
@pzygielo

This comment was marked as resolved.

Sign in to view
@slawekjaranowski slawekjaranowski merged commit a19f27e into apache:master Jan 27, 2025
26 checks passed
@pzygielo pzygielo deleted the unused branch January 27, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pzygielo @slawekjaranowski