Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Dec 13, 2024

No description provided.

@elharo elharo marked this pull request as ready for review December 13, 2024 19:44
@elharo elharo requested a review from hboutemy December 13, 2024 19:44

private final MojoExecution mojoExecution;

public MyMojo(MyComponent component, MavenSession session, MavenProject project, MojoExecution mojoExecution) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Inject annotation missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@elharo elharo changed the title Update documnent to use Guice constructor injection Update document to use Guice constructor injection Dec 15, 2024
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be also updated for 3.x branch?

@elharo
Copy link
Contributor Author

elharo commented Dec 23, 2024

Should be also updated for 3.x branch?

Do we publish both?

@elharo elharo merged commit 4a5fe6a into master Dec 23, 2024
57 checks passed
@elharo elharo deleted the elharo-patch-2 branch December 23, 2024 16:35
@slawekjaranowski slawekjaranowski added the documentation Improvements or additions to documentation label Oct 14, 2025
@slawekjaranowski slawekjaranowski added this to the 4.0.0-beta-2 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants