adds maxTries and retryDelay#3
Closed
bdt-stru wants to merge 3 commits into
Closed
Conversation
maxTries lets the plugin try signing multiple times if first tries fail. Useful when used with a Time Stamp Authority. Default is 1 so backwards compatibility is fully kept.
Member
|
thx for the proposition - could you also add test cases for new retry delay parameter? |
slachiewicz
requested changes
Jan 19, 2020
slachiewicz
left a comment
Member
There was a problem hiding this comment.
please also rebase on MJARSIGNER-41 branch
Author
|
i wont be working on this anymore. feel free to do whatever you like. |
This was referenced Dec 4, 2023
Contributor
|
superseded by #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
includes improvements to previous pull request #1
https://jira.apache.org/jira/projects/MJARSIGNER/issues/MJARSIGNER-41