[MJARSIGNER-63] Exposing certchain on site sign-goal documentation#14
Conversation
elharo
left a comment
There was a problem hiding this comment.
I'm not sure about this. If it should be read only, it should be read only. The docs are an after thought. Maybe the report or site plugin needs to be fixed to handle this?
|
I looked at https://maven.apache.org/plugin-tools/apidocs/org/apache/maven/plugins/annotations/Parameter.html#readonly() and my interpretation of this annotation parameter is that it exist for a use case it don't fully understand (usage of common POM elements). My guess is that this readonly parameter is not related to Java attribute immutability. I'm also (mostly guessing) that the original author (@olamy ?) copy-pasted from the "wrong" thing. Perhaps from MavenProject/Settings/MavenSession? My assumption is that the intention is that the end-user should be able to configure this parameter in a |
add3bc5 to
467bf50
Compare
|
I have rebased this pull request on master. |
|
readonly is not about documentation. See https://maven.apache.org/plugin-tools/maven-plugin-annotations/apidocs/org/apache/maven/plugins/annotations/Parameter.html#readonly() |
|
It's possible that this should not have readonly=true. I don't have a real opinion on that. But let's make sure we're making conscious choice here and the PR title reflects what we're trying to do. |
|
Even though My opinion is that we (the community) should make a conscious choice to make sure that this parameter is configurable by the end-user (and also documented). I think this was the original intent of https://issues.apache.org/jira/projects/MJARSIGNER/issues/MJARSIGNER-53 |
|
Resolve #108 |
Making certchain not read-only so that the Maven site documentation will make is visible on https://maven.apache.org/plugins/maven-jarsigner-plugin/sign-mojo.html