[MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5#2
Conversation
|
missing jira |
| || endsWithIgnoreCase( entryName, ".RSA" ) || endsWithIgnoreCase( entryName, ".EC" ); | ||
| protected static boolean isSignatureFile(String entryName) { | ||
| if (entryName.regionMatches(true, 0, "META-INF", 0, 8)) { | ||
| entryName = entryName.replace('\\', '/'); |
There was a problem hiding this comment.
This replacement is invalid, it should be dropped.
There was a problem hiding this comment.
Please file an issue for that. These lines are changing only because parent pom 39 requires reformatting. Byte code should be identical.
| entryName = entryName.replace( '\\', '/' ); | ||
| protected static boolean isManifestFile(String entryName) { | ||
| if (entryName.regionMatches(true, 0, "META-INF", 0, 8)) { | ||
| entryName = entryName.replace('\\', '/'); |
| <surefire.version>2.21.0</surefire.version> | ||
| <mavenVersion>3.0</mavenVersion> | ||
| <javaVersion>7</javaVersion> | ||
| <mavenVersion>3.2.5</mavenVersion> |
There was a problem hiding this comment.
In will be good to have changing Maven version and JDK requirement in separate change with separate issue.
There was a problem hiding this comment.
I can expand the issue, but it's not really possible. Changing the parent pom required changing a bunch of other things.
There was a problem hiding this comment.
java version upgrade must be separate issue
|
JIRA added |
|
I can file another issue but it has to be one PR. |
|
Missing Jira in commit message - not only in PR header. We add one commit to change pom, one another to reformat and then another to ignore formatting. |
|
Reformatting is, perhaps unfortunately, a fundamental and unavoidable part of the upgrade to parent pom 39 due to the way the new parent pom is configured. Without the reformat the build is broken. Now that I think about it, splitting this into separate commits as I have done in some of these upgrade PRs means that the build is broken at the commit that changes the parent pom version. That's going to make |
|
we have different practice in other our repos. First commit with parent update - usualy also cleanup to plugins, remove redundant after upgrade entries. |
|
|
|
About Java 8 upgrade - also separate from parent upgrade to avoid user confusion - agreed long time ago with Robert and followed in other repos. |
|
Or if @michael-o says that this PR is ok - ok, no need to correct. |
michael-o
left a comment
There was a problem hiding this comment.
Why not first upgrade Maven? Then upgrade parent with reformat and not intermediate commits and then the rest? Result is three commits.
|
Maybe that would work. I'm not sure. My general approach is that anything that gets pulled in as a requirement of whatever I'm trying to do (upgrade to 39) is fine as part of that upgrade. I have limited appetite for a combinatorial explosion of all possible orders of individual changes, and I do think we need to pay attention to the amount of time we're burning on super strict commit processes. |
|
Should we delete the branch? |
|
i'll leave this to @elharo maybe he wants to pickup something more from his branch |
This project had gotten quite far behind so this ended up pulling in a lot of other upgrades too.