[MNG-5600] Dependency management import should support exclusions #59
Conversation
rfscholte
left a comment
There was a problem hiding this comment.
Based on my first analysis I don't think we should add this the pom 4.0.0m the negative impact might be too big. We need a new specification to have better support for such usecase.
...rc/test/java/org/apache/maven/it/MavenITmng5600DependencyManagementImportExclusionsTest.java
Outdated
Show resolved
Hide resolved
| <version>0</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| <exclusions> |
There was a problem hiding this comment.
This IT doesn't reflect MNG-5600. The requests asks for exclusion of transitive dependencies, not direct dependencies.
To me excluding direct dependencies does not make sense.
There was a problem hiding this comment.
I don't get you. If you exclude a dependency, then the actual excluded dependency and its all transitive dependencies are excluded. Maybe I misinterpret the change. Please clarify it
There was a problem hiding this comment.
@rfscholte that is exactly the case. Sometimes you import another pom that is itself a dependencyManagement like spring-boot-dependencies
| @@ -0,0 +1,43 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
I don't understand the need for this file
There was a problem hiding this comment.
The original author does not respond, so try to figure out. The repository contains 201 XML file with the same name but with different content. If you are familiar with IT tests in Maven you could tell is it needed or not. I guess the author wanted to follow convention.
The original patch is made by: Christian Schulte <schulte@apache.org>
|
Superseded by #269 |
The original patch is made by: Christian Schulte schulte@apache.org
@ChristianSchulte
For more information kindly ask you to visit the original pull request #30