[MNG-5693] Remove check for link to cwiki #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibor17
reviewed
Aug 19, 2019
| int url = indexOf( lines, ".*http://cwiki.apache.org/confluence/display/MAVEN/AetherClassNotFound.*" ); | ||
| assertTrue( "Url to ClassNotFoundAether was not found in output.", url >= 0 ); | ||
|
|
||
| boolean versionWithMng5693 = matchesVersionRange( "[3.6.1,)"); // no more link to cwiki |
Contributor
There was a problem hiding this comment.
Why we keep this waiting for 8 months?
The hint was printed by older Maven?
michael-o
reviewed
Aug 19, 2019
| int url = indexOf( lines, ".*http://cwiki.apache.org/confluence/display/MAVEN/AetherClassNotFound.*" ); | ||
| assertTrue( "Url to ClassNotFoundAether was not found in output.", url >= 0 ); | ||
|
|
||
| boolean versionWithMng5693 = matchesVersionRange( "[3.6.1,)"); // no more link to cwiki |
Member
There was a problem hiding this comment.
Why not change this in super()? The test will be obsolete with 3.6.2?!
Contributor
There was a problem hiding this comment.
I think he is checking that next versions do not have that link either. If it is @slachiewicz 's purpose, then super() would not help.
@michael-o Question I asked on ML, why do we keep ITs for old versions. We don't need them. We are tesing SNAPSHOT version and we do not do it backwards for the old versions. Old versions are over, and there I would propose to TAG this project with every Maven release. Then delete the non-general ITs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.