Skip to content

[MNG-7706] Fix for ITs#245

Merged
cstamas merged 1 commit intoapache:masterfrom
cstamas:MNG-7706-fix
Feb 23, 2023
Merged

[MNG-7706] Fix for ITs#245
cstamas merged 1 commit intoapache:masterfrom
cstamas:MNG-7706-fix

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Feb 23, 2023

The MNG-7706 deprecates ancient ArtifactRepository type use to get access to local repository, and issues warning as for any other deprecated Mojo parameters.

But alas, in ITs the MNG-5576 completely unrelated IT there is an assertion to have WARNING-free log. This IT uses the IT-plugins/IT-plugin-expression EvalMojo, that in turn uses the deprecated ${localRepository} parameter (but does not use it). Result is, Maven 3.9.1 emits a WARNING about use of deprecated parameter and the IT fails.

Further inspection shows, that while EvalMojo injects ArtifactRepository for local repository, there is only one IT that actually uses it, the MNG-4305, but even that one is interested in basedir of the local repository only. So to say, the use of deprecated ArtifactRepository type is not needed at all.

Fix:

  • change EvalMojo to not expose in context the localRepository (w/ type ArtifactRepository), but a new expression localRepositoryBasedir only, that is injected in non-deprecated way (in real life repoSysSession would be injected, but in IT we keep all super-safe and use Object types).
  • adjusted MNG-4305 to use new epxression instead to use object reflection in template to get basedir from ArtifactRepository
  • This makes the originally failing MNG-5576 pass, as warning due EvalMojo is gone.

See
https://issues.apache.org/jira/browse/MNG-7706
apache/maven#1009

The MNG-7706 deprecates ancient ArtifactRepository type use to
get access to local repository, and issues warning as for any
other deprecated Mojo parameters.

But alas, in ITs the MNG-5576 completely unrelated IT there is
an assertion to have WARNING-free log. This IT uses the
IT-plugins/IT-plugin-expression EvalMojo, that in turn
uses the deprecated `${localRepository}` parameter (but
does not use it). Result is, Maven 3.9.1 emits a WARNING
about use of deprecated parameter and the IT fails.

Further inspection shows, that while EvalMojo injects
ArtifactRepository for local repository, there is only
one IT that actually uses it, the MNG-4305, but even that
one is interested in basedir of the local repository only.
So to say, the use of deprecated ArtifactRepository is
not needed at all.

Fix:
* change EvalMojo to not expose in context the localRepository
  (w/ type ArtifactRepository), but a new expression `localRepositoryBasedir`
  only, that is injected in non-deprecated way.
* adjusted MNG-4305 to use new epxression instead to use object reflection in
  template to get basedir from ArtifactRepository
* This makes the originally failing MNG-5576 pass, as warning due EvalMojo
  is gone.

See
https://issues.apache.org/jira/browse/MNG-7706
apache/maven#1009
@cstamas cstamas self-assigned this Feb 23, 2023
@cstamas cstamas merged commit 046a94e into apache:master Feb 23, 2023
@cstamas cstamas deleted the MNG-7706-fix branch February 23, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant