Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Aug 30, 2023

40 breaks integration tests, so take this one step at a time.

@elharo elharo requested a review from slachiewicz August 30, 2023 11:50
@slachiewicz
Copy link
Member

Separate commit for version upgrade and then 2nd with reformat so we can add it to ignored

Copy link
Member

@slachiewicz slachiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a new line type issue. I see the full file changes

@elharo
Copy link
Contributor Author

elharo commented Aug 30, 2023

That would mean there's a commit that doesn't build.

@slachiewicz
Copy link
Member

Yes. That's how we do in all repos

@slachiewicz
Copy link
Member

You have duplicate license headers

@slachiewicz
Copy link
Member

Superseded by #119

@jira-importer
Copy link

Resolve #205

1 similar comment
@jira-importer
Copy link

Resolve #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants