Skip to content

Conversation

@ayeseeem
Copy link
Contributor

@ayeseeem ayeseeem commented Sep 6, 2024

The example XML snippet has <configuration> as a closing tag instead of </configuration> - is should start with </ as it's the end tag.

When the example is copied into a POM, the created POM is invalid.


Note: contribution guidelines say I don't need to create a JIRA issue for a small doc fix,
so not everything ticked below:

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MDEPLOY-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MDEPLOY-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

The example XML snippet has `<configuration>` as a closing tag instead of `</configuration>` - is should start with `</` as it's the end tag.

When the example is copied into a POM, the created POM is invalid.
@slachiewicz slachiewicz merged commit db88aa3 into apache:master Sep 29, 2024
@slawekjaranowski slawekjaranowski added this to the 4.0.0-beta-2 milestone Feb 5, 2025
@slawekjaranowski slawekjaranowski added the bug Something isn't working label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants