-
Notifications
You must be signed in to change notification settings - Fork 185
[MDEP-689] Fixes ignored dependency filtering in go-offline goal #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDEP-689] Fixes ignored dependency filtering in go-offline goal #417
Conversation
slawekjaranowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are working on get rid of m-artifact-trafsfer - MDEP-858
but change looks ok.
src/main/java/org/apache/maven/plugins/dependency/resolvers/GoOfflineMojo.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate code
|
Do you know what is required to get a Jira account so I can make comments on the tickets? I've tried emailing various aliases and done the self-serve account request with no luck. It's been almost 2 months since my request. I'll work on addressing your comments here in the next week or so.
I'm not sure how this relates to this PR, can you give me more info about what you mean? |
Apologies, that one must've slipped through. I approved your self-serve account request a minute ago. |
src/test/resources/unit/go-offline-test/exclude-plugin-config.xml
Outdated
Show resolved
Hide resolved
get rid of |
|
@slawekjaranowski Can we go ahead and merge this one? |
|
Resolve #1199 |
|
any idea when this fix will be released? |
I hope in next week ... 😄 |
Duplicate issues MDEP-725 and MDEP-568
Results in attempted resolution of all of the excluded parameters. Looking at the GoOfflineMojo class, the filters were clearly never wired into the doExecute logic. This PR fixes that and adds some unit and integration tests.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MDEP-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MDEP-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.