Skip to content

ConstantPoolParser throws raw RuntimeException #145

@elharo

Description

@elharo

Affected version

HEAD

Bug description

from parseConstantPoolClassReferences which is reading external data (.class files specifically) so this really should be a checked exception, but even if we leave it a runtime exception it should be a more semantically meaningful subclass per Effective Java. Maybe something like java.io.InvalidClassException?

Furthermore, it's a bug because the code in visitClass that ultimately invokes this private method does not catch RuntimeException, only more specific subclasses like IllegalArgumenException.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions