Maven clean build failure when maven.build.cache.failFast=true#412
Merged
Conversation
|
created during hack.commit.push event |
elharo
reviewed
Dec 1, 2025
Contributor
Author
|
@elharo thank you for the review. I assume you follow the policy to clean up the code around specific changes related to a specific feature? It's a good practice, I wasn't aware that you guys follow it. Thanks for pointing out. |
Contributor
Author
|
@sparsick hey Sandra, I applied spotless (too late) - please re-run the pipeline when you have a chance. Thanks! |
sparsick
approved these changes
Dec 1, 2025
|
@sparsick The PR can't be associated to a milestone, because there are multiple open milestones. Please add the text "branch: master" to the description to the milestone where this PR belongs to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @sebtiem we decided to skip the
build-cache-extensionexecution when the singlecleangoal is called.We wrote integration tests to verify that it is only skipped when the single
cleangoal is called.Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.