Skip to content

Maven clean build failure when maven.build.cache.failFast=true#412

Merged
sparsick merged 5 commits into
apache:masterfrom
mavilov:master
Dec 2, 2025
Merged

Maven clean build failure when maven.build.cache.failFast=true#412
sparsick merged 5 commits into
apache:masterfrom
mavilov:master

Conversation

@mavilov

@mavilov mavilov commented Nov 22, 2025

Copy link
Copy Markdown
Contributor

As discussed with @sebtiem we decided to skip the build-cache-extension execution when the single clean goal is called.
We wrote integration tests to verify that it is only skipped when the single clean goal is called.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@sparsick

Copy link
Copy Markdown

created during hack.commit.push event

@elharo elharo requested a review from olamy December 1, 2025 13:09
Comment thread src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java Outdated
Comment thread src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java Outdated
Comment thread src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java Outdated
@mavilov

mavilov commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

@elharo thank you for the review. I assume you follow the policy to clean up the code around specific changes related to a specific feature? It's a good practice, I wasn't aware that you guys follow it. Thanks for pointing out.

@elharo elharo requested a review from sparsick December 1, 2025 16:17
@mavilov

mavilov commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

@sparsick hey Sandra, I applied spotless (too late) - please re-run the pipeline when you have a chance. Thanks!

@olamy olamy added the enhancement New feature or request label Dec 2, 2025

@olamy olamy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sparsick sparsick merged commit 90ade09 into apache:master Dec 2, 2025
22 checks passed
@github-actions

github-actions Bot commented Dec 2, 2025

Copy link
Copy Markdown

@sparsick The PR can't be associated to a milestone, because there are multiple open milestones. Please add the text "branch: master" to the description to the milestone where this PR belongs to.

@sparsick sparsick added this to the 1.2.2 milestone Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants