Skip to content

Automatically format and sort imports according to the maven coding style #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gnodet wants to merge 2 commits into from
Closed

Automatically format and sort imports according to the maven coding style #824

gnodet wants to merge 2 commits into from

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented Oct 12, 2022 •
edited
Loading

Automatically format and sort imports according to the maven coding style.
This requires apache/maven-shared-resources#1

@gnodet gnodet mentioned this pull request Oct 12, 2022
Merged
@gnodet gnodet changed the title autoformat Automatically format and sort imports according to the maven coding style Oct 12, 2022
@gnodet gnodet force-pushed the autoformat branch 4 times, most recently from 3f27ec3 to 99dacf6 Compare October 14, 2022 08:37
gnodet added 2 commits October 14, 2022 10:38
@gnodet
Use spotless to enforce strict code formatting
f1aa72b 
By default, spotless will check and fail the build.
If -Dformat or -Pformat is passed on the command line, spotless will reformat the code instead of checking it.
Disable checkstyle checks already enforced by spotless.
@gnodet
Reformat
606a2ff
@gnodet gnodet marked this pull request as draft October 14, 2022 08:48
@gnodet
Copy link
Contributor Author

gnodet commented Oct 14, 2022

Converted to draft, as it will be cleaner to move those config bits in the parent, after https://lists.apache.org/thread/ok9qdl1w92f9fhdkz3tmc5f65ytpppqp and https://lists.apache.org/thread/md6do2dllt9cv4s311y3ky6245xmvd0w discussions have settled.

@gnodet
Copy link
Contributor Author

gnodet commented Nov 22, 2022

Superseded by #880

@gnodet gnodet closed this Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cstamas cstamas cstamas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gnodet @cstamas