Skip to content

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented Dec 1, 2021

This is a slightly modified version of the patch outlined in https://issues.apache.org/jira/browse/MNG-7335 by @famod.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@gnodet gnodet requested a review from michael-o December 1, 2021 14:45
@gnodet
Copy link
Contributor Author

gnodet commented Dec 1, 2021

Added an integration test at apache/maven-integration-testing#127

@famod
Copy link
Contributor

famod commented Dec 1, 2021

Funnily, the frist approach to MNG-6843 back then was also cloning...which @rfscholte didn't like that much: #310 (comment)

@gnodet
Copy link
Contributor Author

gnodet commented Dec 2, 2021

Funnily, the frist approach to MNG-6843 back then was also cloning...which @rfscholte didn't like that much: #310 (comment)

Thx for the pointer. That lead me to have a closer look and come up with #625 which I think is a better fix.

@gnodet
Copy link
Contributor Author

gnodet commented Dec 2, 2021

Closing this one in favour of #625

@gnodet gnodet closed this Dec 2, 2021
@jira-importer
Copy link

Resolve #8102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants