Skip to content

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented May 12, 2025

Simple changes that makes build/ITs work with Java 24.

PR does not contains:

  • action addition of Java 24 to CI
  • updated Eclipse Sisu version (needed for that above)

https://issues.apache.org/jira/browse/MNG-8727

Simple changes that makes build/ITs work with Java 24.

PR does not contains:
* action addition of Java 24 to CI
* updated Eclipse Sisu version (needed for that above)

---

https://issues.apache.org/jira/browse/MNG-8727
@cstamas cstamas self-assigned this May 12, 2025
@cstamas cstamas added this to the 4.0.0-rc-4 milestone May 12, 2025
@cstamas cstamas marked this pull request as ready for review May 12, 2025 20:08
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that related ?

Copy link
Member Author

@cstamas cstamas May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, older PMD craps out on Java 24. This basically just ups the PMD dependency used by m-pmd-p to one that works on Java 24. No other code change needed.

This fixes the "full-build" step that builds site that uses PMD report.

Copy link
Contributor

@Pankraz76 Pankraz76 May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cstamas cstamas requested a review from michael-o May 12, 2025 20:40
<groupId>org.apache.groovy</groupId>
<artifactId>groovy</artifactId>
<version>4.0.15</version>
<version>4.0.26</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a property?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an IT and this version moves first time since IT was added... I may be a property, but ... meh

Copy link
Member Author

@cstamas cstamas May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Groovy 4.0.26 contains ASM 9.7.1, and no newer release so far. I guess there will be once Java 26 is out? So this version will change once we move/add to CI to Java 26+

@cstamas cstamas merged commit ffd30a3 into apache:master May 13, 2025
13 checks passed
@cstamas cstamas deleted the MNG-8727 branch May 13, 2025 08:42
@jira-importer
Copy link

Resolve #9569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants