-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[MNG-8727] Prepare for Java 24 #2328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Simple changes that makes build/ITs work with Java 24. PR does not contains: * action addition of Java 24 to CI * updated Eclipse Sisu version (needed for that above) --- https://issues.apache.org/jira/browse/MNG-8727
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-pmd-plugin</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that related ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, older PMD craps out on Java 24. This basically just ups the PMD dependency used by m-pmd-p to one that works on Java 24. No other code change needed.
This fixes the "full-build" step that builds site that uses PMD report.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to see things go, in same direction.
impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java
Show resolved
Hide resolved
| <groupId>org.apache.groovy</groupId> | ||
| <artifactId>groovy</artifactId> | ||
| <version>4.0.15</version> | ||
| <version>4.0.26</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be a property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an IT and this version moves first time since IT was added... I may be a property, but ... meh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Groovy 4.0.26 contains ASM 9.7.1, and no newer release so far. I guess there will be once Java 26 is out? So this version will change once we move/add to CI to Java 26+
|
Resolve #9569 |
Simple changes that makes build/ITs work with Java 24.
PR does not contains:
https://issues.apache.org/jira/browse/MNG-8727