[MNG-8719] Restore Maven3 compat: model setInherited(boolean) #2288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added it as deprecated indirection for legacy code. --- https://issues.apache.org/jira/browse/MNG-8719
gnodet
approved these changes
May 3, 2025
elharo
requested changes
May 5, 2025
Contributor
elharo
left a comment
There was a problem hiding this comment.
Needs a test. Otherwise it's likely to be deleted again.
Member
Author
Maven never had nor currently have tests for generated model. It was dropped last year by this commit: |
Member
Author
|
I will skip adding test to it, as this is deprecated method anyway, and serves sole purpose of re-adding compatibility for very old codebases (type of inherited with was changed to String long time ago, around 3.0-RC1 or so). |
|
Resolve #9580 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added it as deprecated indirection for legacy code.
It was removed 1y ago probably by mistake by this commit:
2a9f393
https://issues.apache.org/jira/browse/MNG-8719