[IT] Refactor executor #2175
Merged
[IT] Refactor executor #2175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was overlapping concerns, so better to separate them. Also, this now allows to use tool with other maven that the one being tested, so result should not be affected. Also contains fix for ExecutorTool implementation to enforce that process do produce output, as under some circumstances (on Windows) the process may exit with 0 exit code (no error) but produce empty output on standard output, which should not be possible.
Closed
gnodet
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was overlapping concerns, so better to separate them. Also, this now allows to use tool with other maven that the one being tested, so result should not be affected.
Also contains fix for ExecutorTool implementation to enforce that process do produce output, as under some circumstances (on Windows) the process may exit with 0 exit code (no error) but produce empty output
on standard output, which should not be possible.