[MNG-8535] Ability to capture stdout with maven-executor #2057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
reviewed
Jan 24, 2025
| try (Invoker invoker = createInvoker()) { | ||
| return invoker.invoke(parseArguments(args)); | ||
| ParserRequest.Builder parserRequestBuilder = parserRequestBuilder(args); | ||
| if (in != null) { |
Contributor
There was a problem hiding this comment.
Aren't those checks useless ?
It's definitely no big deal, but
ParserRequest parserRequestBuilder = parserRequestBuilder(args)
.in(in).out(out).err(err)
.build();
|
|
||
| protected void doConfigureWithTerminal(C context, Terminal terminal) { | ||
| context.terminal = terminal; | ||
| MessageUtils.setColorEnabled(Objects.requireNonNullElseGet( |
Contributor
There was a problem hiding this comment.
Why do we have two calls to MessageUtils.setColorEnabled ? Shouldn't only one be sufficient ?
| try { | ||
| if (r.stdoutConsumer().isPresent() | ||
| || r.stderrConsumer().isPresent()) { | ||
| System.setProperty("org.jline.terminal.output", "out"); |
Contributor
There was a problem hiding this comment.
We don't have JLine in the classpath, right ? Else TerminalBuilder.PROP_OUTPUT would be more appropriate.
| .jansi(false) | ||
| .jna(false) | ||
| .jni(true) | ||
| .name("Maven"); |
Contributor
There was a problem hiding this comment.
We may still want to have dumb(true).
For example if we are on an unsupported os/architecture combination, we'll end up with a dumb terminal, but with an annoying warning (and nothing the user can do)...
Currently JAnsi always goes for system out via Process file handle. --- https://issues.apache.org/jira/browse/MNG-8535
Member
Author
|
This PR is superseded by several others. Dropping this one. |
|
Resolve #9907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Needs jline/jline3#1160
https://issues.apache.org/jira/browse/MNG-8535