Skip to content

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Oct 4, 2024

Changes:

  • there is only one parser for "just maven", no need for 3
  • aligned scopes (public) of local context for simplicity, we can fix visibility later
  • allow custom guice modules (unused, may undo this)
  • split logging setup in two steps: config and activate

https://issues.apache.org/jira/browse/MNG-8283

All public scope should be public for simplicity (we can sort
out that later).

Allow custom Guice modules, but not that this is NOT the preferred
method of extending maven.
@cstamas cstamas self-assigned this Oct 4, 2024
@cstamas cstamas requested a review from gnodet October 4, 2024 13:58
Local and Resident invoker both use _same_ parser, the
DefaultMavenParser that is reusable across all "just maven"
invokers.
@cstamas cstamas changed the title More mvnd related changes [MNG-8283] More mvnd related changes Oct 4, 2024
@cstamas cstamas marked this pull request as ready for review October 4, 2024 15:30
@cstamas cstamas merged commit 60ae468 into apache:master Oct 4, 2024
@cstamas cstamas deleted the more-mvnd branch October 4, 2024 15:33
@jira-importer
Copy link

Resolve #9978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants