[maven-3.9.x] Make maven.config use UTF8 #11264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven embedder uses system default encoding, making builds non portable. Fixes apache#11258 This MUST be emphasized in release notes, as issue describes, people may circumvented this by using `-Dfile.encoding=...` that will break if they did not use UTF8.
Member
Author
|
Nota bene: AFAIK on macos and (fairly modern) linux distros default encoding is UTF8 since a while, but not on Windows. Hence, this change, if affect anyone, is most probably those on OS not using UTF8 encoding already. |
slawekjaranowski
approved these changes
Oct 14, 2025
Member
|
I'm not sure to adding a prefix like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven embedder uses system default encoding, making builds non portable.
Fixes #11258
This MUST be emphasized in release notes, as issue describes, people may circumvented this by using
-Dfile.encoding=...that will break if they did not use UTF8.