Remove unused MultiLeafKnnCollector and BlockingFloatHeap#15686
Merged
mayya-sharipova merged 1 commit intoapache:mainfrom Feb 9, 2026
Merged
Remove unused MultiLeafKnnCollector and BlockingFloatHeap#15686mayya-sharipova merged 1 commit intoapache:mainfrom
mayya-sharipova merged 1 commit intoapache:mainfrom
Conversation
These classes are no longer used after PR apache#14226 and apache#15063 switched KNN queries to optimistic collection strategy. The previous approach used MultiLeafKnnCollector with a shared BlockingFloatHeap to exchange top scores across segments during concurrent search. This caused non-deterministic results due to race conditions in score synchronization between threads.
benwtrent
approved these changes
Feb 9, 2026
Member
benwtrent
left a comment
There was a problem hiding this comment.
Thank you for cleaning this up @mayya-sharipova !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These classes are no longer used after PR #14226 and #15063
switched KNN queries to optimistic collection strategy.
The previous approach used MultiLeafKnnCollector with a shared
BlockingFloatHeap to exchange top scores across segments during
concurrent search. This caused non-deterministic results due to
race conditions in score synchronization between threads.