Skip to content

clean up smoketester GPG leaks#12882

Open
hurutoriya wants to merge 1 commit intoapache:mainfrom
hurutoriya:patch-2
Open

clean up smoketester GPG leaks#12882
hurutoriya wants to merge 1 commit intoapache:mainfrom
hurutoriya:patch-2

Conversation

@hurutoriya
Copy link
Copy Markdown

@hurutoriya hurutoriya commented Dec 6, 2023 •
edited
Loading

Description

#11948

@rmuir smoketester leaks a GPG agent on my computer everytime it runs. @risdenk pointed out this fix from solr: apache/solr@0cfef74

This closes #11948

@uschindler uschindler requested a review from rmuir December 6, 2023 15:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2024

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions bot added the Stale label Jan 8, 2024
janhoy
janhoy approved these changes Jan 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct.
Hard to test without dry-running a release, however it could be an idea to setup a Jenkins build for smoke testing, like Solr has in https://ci-builds.apache.org/job/Solr/job/Solr-Smoketest-9.4/

@github-actions github-actions bot removed the Stale label Jan 14, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 30, 2024

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions bot added the Stale label Jan 30, 2024
@janhoy
Copy link
Copy Markdown
Contributor

janhoy commented Jan 30, 2024

@hurutoriya Did you do any testing on the changes? If not, we need to QA that the script is not broken by this change.

@github-actions github-actions bot removed the Stale label Jan 31, 2024
@hurutoriya
Copy link
Copy Markdown
Author

hurutoriya commented Feb 5, 2024

@janhoy Thank you for suggestion. I've never do the QA.

If not, we need to QA that the script is not broken by this change.

OK, let me try the QA 🙏 .
How should I do for QA? (I will try understand a concrete step)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 20, 2024

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions bot added the Stale label Feb 20, 2024
@github-actions github-actions bot removed the Stale label Oct 1, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 17, 2025

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions bot added the Stale label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janhoy janhoy janhoy approved these changes

@risdenk risdenk risdenk approved these changes

@rmuir rmuir Awaiting requested review from rmuir

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clean up smoketester GPG leaks

3 participants

@hurutoriya @janhoy @risdenk