GH#12321: Reduce visibility of StringsToAutomaton#12331
Merged
gsmiller merged 2 commits intoapache:mainfrom May 26, 2023
Merged
GH#12321: Reduce visibility of StringsToAutomaton#12331gsmiller merged 2 commits intoapache:mainfrom
gsmiller merged 2 commits intoapache:mainfrom
Conversation
Users should rely on Automata#makeStringUnion instead
Contributor
|
Please add info to the MIGRATE.txt like @mikemccand did in the other PR. |
Contributor
|
We should add (in a separate PR) the static method to 9.x, too. |
Contributor
Author
|
Created a separate PR for the "backport" of this work here: #12332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As described in #12321, we can reduce our API surface area by making
StringsToAutomatonpkg-private and asking users to go throughAutomatafactory methods.NOTE: I'm proposing this change goes with 10.0. I would mark
StringsToAutomatonas@deprecatedon 9.x.